Repository navigation
Conversation
ericdog
force-pushed
the
ericlim/internal-buildx-modern-docker-20261103
branch
from
November 3, 2026 15:42
edda1eb to
0970e69
Compare
ericdog
marked this pull request as ready for review
November 4, 2026 16:26
Author
|
/ddci trigger |
|
View all feedbacks in Devflow UI.
Tasks sourcing running asynchronously in workflow devflow:4924896d-a00c-476c-a539-b3c721df0f9f_47:01a1a763-25c5-7b53-9ea7-7b5e2b14c881 under run id 01a1a763-2e2d-7a17-b0cb-f742a5242fe9 |
There was a problem hiding this comment.
With SKIP_PIP_INSTALL unset, the Noble-based layer-publishing jobs still invoke system pip and abort under PEP 668 before publishing any layers.
🤖 Bits Code Review · Commit 0970e69
ericdog
force-pushed
the
ericlim/internal-buildx-modern-docker-20261103
branch
from
November 5, 2026 11:36
1ff3e17 to
628602f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace all Docker 20.10/20.10-py3 CI image references with already-published, digest-pinned images containing internal Buildx v0.37.2-dd.3:
Both image manifests come from merged images/master commit af53db03938b864dfea79025c679312a0479726d (Docker build, Python Docker build). No new image publication is required.
Motivation
The existing Docker images report upstream Buildx v0.8.0 and miss our internal reliability patches. Reuse maintained images instead of creating additional Docker 20.10 variants in images#12452. Related: https://datadoghq.atlassian.net/browse/CIEXE-2681.
Noble's system Python is externally managed, and the published Python image lacks AWS CLI. Install awscli/python3-venv/python-is-python3 before the affected jobs, and create the Python virtual environment before installing dependencies. This preserves the required AWS commands without writing Python packages into the managed system interpreter.
Testing Guidelines
Full container/CI integration validation remains. The local Docker filesystem is nearly full. The commit no longer contains a CI-skip directive. Normal pipelines include automatic sandbox publishing and integration deployments; a deployment-free validation run must set the existing
SKIP_E2E_TESTS=truepipeline variable.Additional Notes
This also upgrades Docker and the Python job OS from the legacy image; reviewers should validate representative layer builds and AWS/Python workflows before merge. Library code, Lambda runtime images, release conditions, and deployment targets are unchanged.
Types of Changes
Check all that apply